Configure udev to symlink attached volumes by tag#64
Merged
Conversation
mkjpryor
force-pushed
the
feature/volumes-by-tag
branch
from
6c43372 to
4903a05
Compare
mkjpryor
force-pushed
the
feature/volumes-by-tag
branch
from
4903a05 to
a8ad01b
Compare
mkjpryor
changed the title
mkjpryor
changed the title
scrungus
reviewed
Jan 17, 2024
scrungus
left a comment
scrungus
left a comment
There was a problem hiding this comment.
I'm not sure I'm fully qualified to understand this code, but from what I can understand it looks ok to me.
JohnGarbutt
approved these changes
Jan 17, 2024
Contributor
JohnGarbutt
left a comment
JohnGarbutt
left a comment
There was a problem hiding this comment.
I hate this being downstream and so custom, but let's try this out.
This doesn't conflict with Cinder CSI attachments I assume?
Contributor
Author
|
I don't think this would get accepted into the CAPI image builder as it is. It would probably need to be a Go binary or something. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.